i think we should set auto-deploy-dsp to false by default. and another point is that now we are using kustomize to generate the deployment.yaml and any required changes related to the discovery-engine deployment should be made in deployments/k8s/default/discovery-engine and the final deployment yaml can be generated using make manifests.

now we are using kustomize to generate the deployment.yaml and any required changes related to the discovery-engine deployment should be made in deployments/k8s/default/discovery-engine and the final deployment yaml can be generated using make generate

@rksharma95 Can we get this documented here?

@rksharma95 Can we get this documented here?

@Ankurk99 we already have basic instructions for making changes to deployment, can you please mention here what other information we need to add, thanks

The automated way of generating the deployment manifest.
make generate

The automated way of generating the deployment manifest. make generate

I am getting this error when trying make generate from discovery-engine/deployments/k8s

make generate                                                                                                   (adm-fix|✔)
make: *** No rule to make target 'generate'.  Stop.

The automated way of generating the deployment manifest. make generate

I am getting this error when trying make generate from discovery-engine/deployments/k8s

make generate                                                                                                   (adm-fix|✔)
make: *** No rule to make target 'generate'.  Stop.

@vishnusomank You can just do a make inside discovery-engine/deployments/k8s
It is displaying as text format. Redirect and store it to a file.

I am getting this error when trying make generate from discovery-engine/deployments/k8s

my bad it's make manifests i mistakenly typed it as make generate in one of my previous comments. please try with make manifests.

and can you please set auto-deploy-dsp to false for local configs too. thanks @vishnusomank